Bug 210273 - [GTK] Clean-up use of deprecated GtkAction
Summary: [GTK] Clean-up use of deprecated GtkAction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-04-09 06:59 PDT by Claudio Saavedra
Modified: 2020-04-09 07:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.12 KB, patch)
2020-04-09 07:04 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2020-04-09 06:59:13 PDT 
[GTK] Clean-up use of deprecated GtkAction
Comment 1 Claudio Saavedra 2020-04-09 07:04:33 PDT 
Created attachment 395946 [details]
Patch
Comment 2 EWS Watchlist 2020-04-09 07:05:11 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Claudio Saavedra 2020-04-09 07:06:20 PDT 
Note that MiniBrowser is still using GtkAction and other APIs that are gone in GTK4. I didn't include that in this patch as it will require more work to redo the UI and we probably want to refresh it anyway a bit.
Comment 4 EWS 2020-04-09 07:48:36 PDT 
Committed r259799: <https://trac.webkit.org/changeset/259799>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395946 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-09 07:49:13 PDT 
<rdar://problem/61517516>