Bug 210271

Summary: [GStreamer][MediaStream] Doesn't build with GStreamer 1.10
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, calvaris, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Alicia Boya García
Reported 2020-04-09 06:47:24 PDT
According to our CMake files, the minimum gst required version for WebRTC is 1.10: if (PC_GSTREAMER_VERSION VERSION_LESS "1.10") message(FATAL_ERROR "GStreamer 1.10 is needed for ENABLE_MEDIA_STREAM or ENABLE_WEB_RTC") On the other hand, I built WebKit with 1.10 and found this error. ../../Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp: In member function ‘virtual rtc::scoped_refptr<webrtc::I420BufferInterface> WebCore::GStreamerVideoFrameLibWebRTC::ToI420()’: ../../Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:126:13: error: ‘GST_VIDEO_CONVERTER_OPT_THREADS’ was not declared in this scope; did you mean ‘GST_VIDEO_CONVERTER_OPT_SRC_X’? GST_VIDEO_CONVERTER_OPT_THREADS is indeed missing from gst-plugins-base 1.10.5 source code, but is present in 1.12.0.
Attachments
Patch (1.29 KB, patch)
2020-04-28 01:47 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-04-28 01:47:15 PDT
Created attachment 397821 [details] Patch
Philippe Normand
Comment 2 2020-04-28 07:15:26 PDT
Committed r260821: <https://trac.webkit.org/changeset/260821>
Note You need to log in before you can comment on or make changes to this bug.