Bug 210192

Summary: [Wincairo, 32bit] adapt script update-wincairo-libs for 32-bit
Product: WebKit Reporter: Thomas Brodt <thomas.brodt>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: don.olmstead, fujii.hironori
Priority: P2 Keywords: Cairo
Version: Other   
Hardware: PC   
OS: Windows 10   
Attachments:
Description Flags
hacky patch for 32bit WinCairo
none
WIP patch
none
Patch none

Thomas Brodt
Reported 2020-04-08 09:51:45 PDT
the Script update-wincairo-libs updates the required libraries for wincairo if necessary. The script however only downloads the 64 bit zip, although 64 and 32 bit versions of the libraries are built (and I currently still need 32bit, and have changed it to download the 32 bit and it works). The script should be enhanced with a switch like that if ('???' == 'x64'): file = 'WebKitRequirementsWin64.zip' else: file = 'WebKitRequirementsWin32.zip' However, I don't know the best test method to decide which dll package should be installed.
Attachments
hacky patch for 32bit WinCairo (3.22 KB, patch)
2020-07-22 14:29 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (537 bytes, patch)
2020-07-29 17:00 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (1.72 KB, patch)
2022-10-27 18:20 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-07-22 14:29:28 PDT
Created attachment 404964 [details] hacky patch for 32bit WinCairo I tested with trunk@264693 and > perl .\Tools\Scripts\build-webkit --wincairo --release --32-bit
Fujii Hironori
Comment 2 2020-07-29 17:00:16 PDT
Created attachment 405529 [details] WIP patch I tested with trunk@265060 and the following command: > perl .\Tools\Scripts\build-webkit --wincairo --release --32-bit
Fujii Hironori
Comment 3 2022-10-27 18:20:14 PDT
Created attachment 463287 [details] Patch Today, I compiled out the latest 32bit WinCairo. 1. Replaced vcvars64.bat to vcvars32.bat of WinCairo command prompt https://trac.webkit.org/wiki/BuildingCairoOnWindows#WinCairocommandprompt 2. Apply the patch 3. perl .\Tools\Scripts\build-webkit --wincairo --32-bit --release It's pretty unstable and crashy. Did AppleWin port give up 32bit?
Note You need to log in before you can comment on or make changes to this bug.