Bug 210164

Summary: Remove ENABLE_INTL define
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, bfulgham, cdumez, cmarcelo, darin, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, jbedard, joepeck, keith_miller, mark.lam, msaboff, olivier.blin, pvollan, ryuan.choi, saam, sergio, stephan.szabo, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2020-04-07 15:33:49 PDT
Remove ENABLE_INTL define
Attachments
Patch (57.42 KB, patch)
2020-04-07 15:46 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-04-07 15:46:23 PDT
Created attachment 395754 [details] Patch
Konstantin Tokarev
Comment 2 2020-04-07 17:07:53 PDT
Why? This is important feature for developers of embedded systems, allowing to cut of some stuff from ICU
Ross Kirsling
Comment 3 2020-04-07 17:15:24 PDT
(In reply to Konstantin Tokarev from comment #2) > Why? This is important feature for developers of embedded systems, allowing > to cut of some stuff from ICU As I wrote in WTF/ChangeLog, AppleWin was the only upstream platform turning it off. We could certainly leave this as an optional feature indefinitely, but it seems a bit problematic if there won't be any bots left to ensure that the build works without it.
Ross Kirsling
Comment 4 2020-04-08 12:51:06 PDT
Note: AppleWin EWS doesn't run JSC tests but I've confirmed that they pass locally.
Ross Kirsling
Comment 5 2020-04-08 14:17:32 PDT
As for downstream platforms -- I believe it's possible to stub out the data portion of ICU such that you can build and link, even if the output wouldn't pass our tests.
EWS
Comment 6 2020-04-08 17:06:04 PDT
Committed r259767: <https://trac.webkit.org/changeset/259767> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395754 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-08 17:07:13 PDT
<rdar://problem/61486343>
Ross Kirsling
Comment 8 2020-04-14 18:03:38 PDT
*** Bug 186020 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.