Bug 210163

Summary: [JSC] Collect-continuously thread should take m_collectContinuouslyLock while it is waking up concurrent collector thread
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2020-04-07 15:29:41 PDT
[JSC] Collect-continuously thread should take m_collectContinuouslyLock while it is waking up concurrent collector thread
Attachments
Patch (6.12 KB, patch)
2020-04-07 15:45 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-07 15:45:53 PDT
Created attachment 395753 [details] Patch
Yusuke Suzuki
Comment 2 2020-04-07 15:46:28 PDT
<rdar://problem/61392945>
Saam Barati
Comment 3 2020-04-07 15:52:04 PDT
Comment on attachment 395753 [details] Patch r=me
Yusuke Suzuki
Comment 4 2020-04-07 16:09:18 PDT
Comment on attachment 395753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395753&action=review > Source/JavaScriptCore/heap/Heap.cpp:2902 > while (!m_shouldStopCollectingContinuously) { I'll put this condition under the lock of m_collectContinuouslyLock
Yusuke Suzuki
Comment 5 2020-04-07 16:25:00 PDT
Committed r259683: <https://trac.webkit.org/changeset/259683>
Note You need to log in before you can comment on or make changes to this bug.