Bug 210160

Summary: [GTK4] Fix usage of GDK event functions in PlatformWheelEventGtk
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, csaavedra, mcatanzaro, svillar
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210154    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch none

Description Adrian Perez 2020-04-07 15:14:17 PDT
WebCore/platform/gtk/PlatformWheelEventGtk.cpp uses deprecated GDK
functions, we'll need alternative code paths for GTK4 in some cases.
Comment 1 Adrian Perez 2020-04-07 15:17:15 PDT
Created attachment 395747 [details]
Patch
Comment 2 Michael Catanzaro 2020-04-07 15:39:56 PDT
Comment on attachment 395747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395747&action=review

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:50
> +#if USE(GTK4)

Wait, are you sure this actually works?

I see you set(GTK_4 TRUE) in FindGTK.cmake, but nothing sets USE_GTK_4.

There's also no way to choose whether you build with GTK 4 or GTK 3 (but I guess that will come later).
Comment 3 Michael Catanzaro 2020-04-07 15:40:03 PDT Comment hidden (obsolete)
Comment 4 Adrian Perez 2020-04-07 17:00:20 PDT
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 395747 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395747&action=review
> 
> > Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:50
> > +#if USE(GTK4)
> 
> Wait, are you sure this actually works?
> 
> I see you set(GTK_4 TRUE) in FindGTK.cmake, but nothing sets USE_GTK_4.
> 
> There's also no way to choose whether you build with GTK 4 or GTK 3 (but I
> guess that will come later).

That would be bug #210154, the patch there needs to be landed first
(note that it a dependency for this bug :D)
Comment 5 EWS 2020-04-13 08:23:36 PDT
Committed r260008: <https://trac.webkit.org/changeset/260008>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395747 [details].