Bug 210159

Summary: Regression(r259610) [RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 209990    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-04-07 15:05:35 PDT 
[RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception since r259610. There are apparently cases where the PID we are passing the ProcessAssertion is 0 (likely process crash on startup). BKSAssertion used to deal with this silently but RBSAssertion actually throws an exception in this case. To maintain the old behavior, we should do an explicit check to make sure the PID is valid before passing it to RunningBoard.
Comment 1 Chris Dumez 2020-04-07 15:07:03 PDT 
Created attachment 395743 [details]
Patch
Comment 2 EWS 2020-04-08 08:37:59 PDT 
Committed r259717: <https://trac.webkit.org/changeset/259717>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395743 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-08 08:38:12 PDT 
<rdar://problem/61456395>