Bug 210159

Summary: Regression(r259610) [RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 209990    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-04-07 15:05:35 PDT
[RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception since r259610. There are apparently cases where the PID we are passing the ProcessAssertion is 0 (likely process crash on startup). BKSAssertion used to deal with this silently but RBSAssertion actually throws an exception in this case. To maintain the old behavior, we should do an explicit check to make sure the PID is valid before passing it to RunningBoard.
Attachments
Patch (2.43 KB, patch)
2020-04-07 15:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-04-07 15:07:03 PDT
Created attachment 395743 [details] Patch
EWS
Comment 2 2020-04-08 08:37:59 PDT
Committed r259717: <https://trac.webkit.org/changeset/259717> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395743 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-08 08:38:12 PDT
<rdar://problem/61456395>
Note You need to log in before you can comment on or make changes to this bug.