Bug 210147

Summary: Delete ICs should not cache dictionaries
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Saam Barati
Reported 2020-04-07 13:28:24 PDT
...
Attachments
patch (3.52 KB, patch)
2020-04-07 13:33 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (3.68 KB, patch)
2020-04-07 13:38 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-04-07 13:28:53 PDT
<rdar://problem/61382405>
Saam Barati
Comment 2 2020-04-07 13:33:02 PDT
Created attachment 395730 [details] patch
Saam Barati
Comment 3 2020-04-07 13:34:18 PDT
Comment on attachment 395730 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=395730&action=review > Source/JavaScriptCore/jit/Repatch.cpp:760 > + jsCast<JSObject*>(baseValue)->flattenDictionaryObject(vm); oops, I need to check hasBeenFlattenedBefore
Saam Barati
Comment 4 2020-04-07 13:38:15 PDT
Created attachment 395732 [details] patch
Tadeu Zagallo
Comment 5 2020-04-07 14:50:13 PDT
Comment on attachment 395732 [details] patch r=me
EWS
Comment 6 2020-04-07 16:11:26 PDT
Committed r259681: <https://trac.webkit.org/changeset/259681> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395732 [details].
Note You need to log in before you can comment on or make changes to this bug.