Bug 210137

Summary:

Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

WebDriver

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, hi, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description BJ Burg 2020-04-07 11:50:29 PDT

Comment 1 BJ Burg 2020-04-07 11:56:45 PDT

Created attachment 395719 [details]
Patch

Comment 2 Joseph Pecoraro 2020-04-07 12:46:20 PDT

Comment on attachment 395719 [details]
Patch

rs=me

Comment 3 Devin Rousso 2020-04-07 12:48:28 PDT

Comment on attachment 395719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395719&action=review

r=me

> Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:59
>      if (page->inspector()) {

NIT: why not save this result so you don't have to call it again?
```
    if (auto* inspector = page->inspector())
        inspector->show();
```

Comment 4 EWS 2020-04-07 13:07:52 PDT

Committed r259665: <https://trac.webkit.org/changeset/259665>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395719 [details].

Comment 5 Radar WebKit Bug Importer 2020-04-07 13:08:13 PDT

<rdar://problem/61406816>