| Summary: | [JSC] ScopedArgumentsTable should handle OOM in tolerant manner | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-04-07 09:50:12 PDT
Created attachment 395690 [details]
Patch
Comment on attachment 395690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395690&action=review r=me > Source/JavaScriptCore/runtime/ScopedArguments.cpp:146 > + auto scope = DECLARE_THROW_SCOPE(vm); You’re adding a ThrowScope. Make sure to run JSC stress tests with a debug build (use --force-opt=O3 to run faster) to make sure there’s no new missing exception check failures. Comment on attachment 395690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395690&action=review >> Source/JavaScriptCore/runtime/ScopedArguments.cpp:146 >> + auto scope = DECLARE_THROW_SCOPE(vm); > > You’re adding a ThrowScope. Make sure to run JSC stress tests with a debug build (use --force-opt=O3 to run faster) to make sure there’s no new missing exception check failures. I think this is OK since caller of unmapArgument has proper exception checks. Committed r259646: <https://trac.webkit.org/changeset/259646> |