Bug 210107

Summary: Bump priority of LibWebRTCAudioModule thread
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2020-04-07 06:22:00 PDT
Bump priority of LibWebRTCAudioModule thread. This thread is responsible to get audio samples and push them to audio renderers.
Attachments
Patch (4.21 KB, patch)
2020-04-07 07:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.21 KB, patch)
2020-04-07 07:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.36 KB, patch)
2020-04-09 08:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.65 KB, patch)
2020-04-09 09:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.65 KB, patch)
2020-04-09 23:50 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-04-07 07:09:23 PDT
Created attachment 395676 [details] Patch
youenn fablet
Comment 2 2020-04-07 07:16:09 PDT
Created attachment 395677 [details] Patch
youenn fablet
Comment 3 2020-04-09 08:08:52 PDT
Created attachment 395951 [details] Patch
Eric Carlson
Comment 4 2020-04-09 08:46:54 PDT
Comment on attachment 395951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395951&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:73 > void LibWebRTCAudioModule::StartPlayoutOnAudioThread() This name seems wrong now that it is essentially a one-shot. Maybe something like `PullDataOnAudioThread`, or fold maybe the logic into PollFromSource instead? > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:102 > + char data[(LibWebRTCAudioFormat::sampleByteSize * channels * LibWebRTCAudioFormat::chunkSampleCount)]; Now that the chunk size is constant (for a given channel count), maybe we should use a member variable that is (re)allocated when the number of channels changes?
youenn fablet
Comment 5 2020-04-09 09:04:15 PDT
Created attachment 395960 [details] Patch for landing
EWS
Comment 6 2020-04-09 12:33:41 PDT
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
youenn fablet
Comment 7 2020-04-09 23:50:21 PDT
Created attachment 396053 [details] Patch for landing
EWS
Comment 8 2020-04-10 03:02:29 PDT
Committed r259853: <https://trac.webkit.org/changeset/259853> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396053 [details].
Radar WebKit Bug Importer
Comment 9 2020-04-10 03:03:27 PDT
<rdar://problem/61575334>
Note You need to log in before you can comment on or make changes to this bug.