Bug 210090

Summary: Initialization of modal nodes should happen lazily, not in the AXObjectCache constructor.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2020-04-06 19:27:16 PDT
Initialization of modal nodes should happen lazily, not in the AXObjectCache constructor.
Attachments
Patch (7.50 KB, patch)
2020-04-06 19:45 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (7.54 KB, patch)
2020-04-06 20:38 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-04-06 19:45:26 PDT
Created attachment 395646 [details] Patch
chris fleizach
Comment 2 2020-04-06 19:57:32 PDT
Comment on attachment 395646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395646&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:305 > + m_currentModalNode = currentModalNode(); should currentModalNode() set m_currentModalNode? I feel like that way it can cache the value as needed and return the variable appropriately from one place of access > Source/WebCore/accessibility/AXObjectCache.cpp:318 > + m_currentModalNode = currentModalNode(); then here can just return currentModalNode()
Andres Gonzalez
Comment 3 2020-04-06 20:38:23 PDT
Created attachment 395648 [details] Patch
Andres Gonzalez
Comment 4 2020-04-06 20:41:23 PDT
(In reply to chris fleizach from comment #2) > Comment on attachment 395646 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395646&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:305 > > + m_currentModalNode = currentModalNode(); > > should currentModalNode() set m_currentModalNode? I feel like that way it > can cache the value as needed and return the variable appropriately from one > place of access Done. > > > Source/WebCore/accessibility/AXObjectCache.cpp:318 > > + m_currentModalNode = currentModalNode(); > > then here can just return currentModalNode() Done.
EWS
Comment 5 2020-04-07 04:52:30 PDT
Committed r259633: <https://trac.webkit.org/changeset/259633> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395648 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-07 04:53:18 PDT
<rdar://problem/61388295>
Note You need to log in before you can comment on or make changes to this bug.