Bug 210078

Summary: REGRESSION: 68000 JSC tests failing
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187526
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Truitt Savell
Reported 2020-04-06 16:14:12 PDT
recently 68000 JSC tests began failing. I do not have a solid regression point because the build stopped working on this queue today for a time. Build Queue: https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests?numbuilds=50 Build: https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637 Stdio: https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637/steps/jscore-test/logs/stdio
Attachments
proposed patch. (1.80 KB, patch)
2020-04-06 16:44 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-04-06 16:15:13 PDT
<rdar://problem/61364513>
Mark Lam
Comment 2 2020-04-06 16:36:53 PDT
This failure is caused by https://trac.webkit.org/r259587 for https://bugs.webkit.org/show_bug.cgi?id=187526.
Mark Lam
Comment 3 2020-04-06 16:44:09 PDT
Created attachment 395631 [details] proposed patch.
Yusuke Suzuki
Comment 4 2020-04-06 16:45:51 PDT
Comment on attachment 395631 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=395631&action=review r=me > Source/JavaScriptCore/jsc.cpp:603 > + RELEASE_ASSERT(!catchScope.exception()); how about using EXCEPTION_ASSERT?
Mark Lam
Comment 5 2020-04-06 16:52:31 PDT
Thanks for the review. (In reply to Yusuke Suzuki from comment #4) > > Source/JavaScriptCore/jsc.cpp:603 > > + RELEASE_ASSERT(!catchScope.exception()); > > how about using EXCEPTION_ASSERT? Talked to Yusuke offline. Will use scope.releaseAssertNoException() instead.
Mark Lam
Comment 6 2020-04-06 17:13:35 PDT
Landed in r259614: <http://trac.webkit.org/r259614>.
Note You need to log in before you can comment on or make changes to this bug.