Bug 210057

Summary:

ImageDiff: Don't build with ASan in automation

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ddkilzer, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=209963
https://bugs.webkit.org/show_bug.cgi?id=190327

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Jonathan Bedard 2020-04-06 10:24:26 PDT

ImageDiff is crashing on some iOS Asan bots. This is one of the binaries that probably shouldn't be built with Asan in the first place, since it is not built with the target SDK.

Comment 1 Jonathan Bedard 2020-04-06 10:24:52 PDT

<rdar://problem/61234753>

Comment 2 Jonathan Bedard 2020-04-06 10:36:23 PDT

Created attachment 395584 [details]
Patch

Comment 3 David Kilzer (:ddkilzer) 2020-04-06 11:03:56 PDT

Comment on attachment 395584 [details]
Patch

r=me, although for the record, I always liked the idea of running tools with ASan because it would catch moar boogs.

Comment 4 David Kilzer (:ddkilzer) 2020-04-06 11:04:16 PDT

Comment on attachment 395584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395584&action=review

> Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig:1
> +// Copyright (C) 2009, 2020 Apple Inc. All rights reserved.

Nit: Should be "2009-2020".

Comment 5 Jonathan Bedard 2020-04-06 11:26:56 PDT

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Comment on attachment 395584 [details]
> Patch
> 
> r=me, although for the record, I always liked the idea of running tools with
> ASan because it would catch moar boogs.

For WebKitTetsRunner, TestWebKitAPI and friends, I totally agree. ImageDiff is a special situation, though, because it's always built with the Mac SDK, even when other projects are built with a different SDK (in this case, iOS was the SDK giving us issues).

(just responding so we have a record of why I made this change to this particular tool in case someone wants to un-do this in the future :) )

Comment 6 Jonathan Bedard 2020-04-06 11:31:05 PDT

Created attachment 395595 [details]
Patch for landing

Comment 7 EWS 2020-04-06 13:35:21 PDT

Found 1 new test failure: inspector/canvas/shaderProgram-add-remove-webgpu.html

Comment 8 Jonathan Bedard 2020-04-06 16:46:42 PDT

Comment on attachment 395595 [details]
Patch for landing

Commit queue is clearly wrong, this change could not have broken a test.

Comment 9 EWS 2020-04-06 17:26:39 PDT

Committed r259616: <https://trac.webkit.org/changeset/259616>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395595 [details].