Bug 210033

Summary: [CMake] Add WebKit::WebKit target
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, basuke, berto, ews-watchlist, fujii.hironori, gyuyoung.kim, jmason, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch none

Don Olmstead
Reported 2020-04-05 10:11:46 PDT
Add the target and modernize the WebKit code around it.
Attachments
WIP Patch (43.07 KB, patch)
2020-04-05 10:16 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (47.76 KB, patch)
2020-04-05 11:04 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-04-05 10:16:13 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-04-05 11:04:06 PDT
Created attachment 395517 [details] Patch
Fujii Hironori
Comment 3 2020-04-05 19:21:26 PDT
Comment on attachment 395517 [details] Patch LGTM
EWS
Comment 4 2020-04-05 20:02:59 PDT
Committed r259560: <https://trac.webkit.org/changeset/259560> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395517 [details].
Don Olmstead
Comment 5 2020-04-06 08:01:23 PDT
*** Bug 201001 has been marked as a duplicate of this bug. ***
Jim Mason
Comment 6 2020-04-08 01:29:27 PDT
For me, WebKitPluginProcess is still built but is no longer installed.
Jim Mason
Comment 7 2020-04-08 01:33:28 PDT
(In reply to Jim Mason from comment #6) > For me, WebKitPluginProcess is still built but is no longer installed. This is using the GTK port.
Alberto Garcia
Comment 8 2020-12-26 10:35:31 PST
(In reply to Jim Mason from comment #6) > For me, WebKitPluginProcess is still built but is no longer installed. Thanks, I filed this as bug 220154
Note You need to log in before you can comment on or make changes to this bug.