| Summary: | copy jsc CLI into JavaScriptCore.framework earlier | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | ap, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2020-04-04 22:24:06 PDT
Created attachment 395483 [details]
Patch
Comment on attachment 395483 [details]
Patch
r=me if EWS bots are happy.
Committed r259545: <https://trac.webkit.org/changeset/259545> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395483 [details]. The patch was rolled out in r259548: <http://trac.webkit.org/r259548> because it was causing CodeSigning error in jsc EWS bot. https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the case causing CodeSigning error. (In reply to Yusuke Suzuki from comment #6) > https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the > case causing CodeSigning error. Seems that all EWS bots need to be force-cleaned. Can you find a way to avoid the need for clean builds? That’s something that all engineers will have to do too, so it’s quite costly. (In reply to Alexey Proskuryakov from comment #8) > Can you find a way to avoid the need for clean builds? That’s something that > all engineers will have to do too, so it’s quite costly. I don't think engineers should see the build failure if they didn't build while this was in the tree. The problem was that the jsc CLI was placed into the framework unsigned so the next build errored. In a future patch, I don't think this problem should repeat itself. |