Bug 210018

Summary: copy jsc CLI into JavaScriptCore.framework earlier
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: REOPENED    
Severity: Normal CC: ap, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Miller
Reported 2020-04-04 22:24:06 PDT
copy jsc CLI into JavaScriptCore.framework earlier
Attachments
Patch (5.05 KB, patch)
2020-04-04 22:26 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-04-04 22:26:16 PDT
Created attachment 395483 [details] Patch
Mark Lam
Comment 2 2020-04-04 22:44:10 PDT
Comment on attachment 395483 [details] Patch r=me if EWS bots are happy.
EWS
Comment 3 2020-04-04 23:17:27 PDT
Committed r259545: <https://trac.webkit.org/changeset/259545> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395483 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-04 23:18:14 PDT
<rdar://problem/61309849>
Mark Lam
Comment 5 2020-04-05 01:42:53 PDT
The patch was rolled out in r259548: <http://trac.webkit.org/r259548> because it was causing CodeSigning error in jsc EWS bot.
Yusuke Suzuki
Comment 6 2020-04-05 01:45:04 PDT
https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the case causing CodeSigning error.
Yusuke Suzuki
Comment 7 2020-04-05 01:55:39 PDT
(In reply to Yusuke Suzuki from comment #6) > https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the > case causing CodeSigning error. Seems that all EWS bots need to be force-cleaned.
Alexey Proskuryakov
Comment 8 2020-04-05 10:49:25 PDT
Can you find a way to avoid the need for clean builds? That’s something that all engineers will have to do too, so it’s quite costly.
Keith Miller
Comment 9 2020-04-05 11:14:58 PDT
(In reply to Alexey Proskuryakov from comment #8) > Can you find a way to avoid the need for clean builds? That’s something that > all engineers will have to do too, so it’s quite costly. I don't think engineers should see the build failure if they didn't build while this was in the tree. The problem was that the jsc CLI was placed into the framework unsigned so the next build errored. In a future patch, I don't think this problem should repeat itself.
Note You need to log in before you can comment on or make changes to this bug.