Bug 210018 - copy jsc CLI into JavaScriptCore.framework earlier
Summary: copy jsc CLI into JavaScriptCore.framework earlier
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-04 22:24 PDT by Keith Miller
Modified: 2020-04-05 11:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.05 KB, patch)
2020-04-04 22:26 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-04-04 22:24:06 PDT
copy jsc CLI into JavaScriptCore.framework earlier
Comment 1 Keith Miller 2020-04-04 22:26:16 PDT
Created attachment 395483 [details]
Patch
Comment 2 Mark Lam 2020-04-04 22:44:10 PDT
Comment on attachment 395483 [details]
Patch

r=me if EWS bots are happy.
Comment 3 EWS 2020-04-04 23:17:27 PDT
Committed r259545: <https://trac.webkit.org/changeset/259545>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395483 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-04 23:18:14 PDT
<rdar://problem/61309849>
Comment 5 Mark Lam 2020-04-05 01:42:53 PDT
The patch was rolled out in r259548: <http://trac.webkit.org/r259548> because it was causing CodeSigning error in jsc EWS bot.
Comment 6 Yusuke Suzuki 2020-04-05 01:45:04 PDT
https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the case causing CodeSigning error.
Comment 7 Yusuke Suzuki 2020-04-05 01:55:39 PDT
(In reply to Yusuke Suzuki from comment #6)
> https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the
> case causing CodeSigning error.

Seems that all EWS bots need to be force-cleaned.
Comment 8 Alexey Proskuryakov 2020-04-05 10:49:25 PDT
Can you find a way to avoid the need for clean builds? That’s something that all engineers will have to do too, so it’s quite costly.
Comment 9 Keith Miller 2020-04-05 11:14:58 PDT
(In reply to Alexey Proskuryakov from comment #8)
> Can you find a way to avoid the need for clean builds? That’s something that
> all engineers will have to do too, so it’s quite costly.

I don't think engineers should see the build failure if they didn't build while this was in the tree. The problem was that the jsc CLI was placed into the framework unsigned so the next build errored.

In a future patch, I don't think this problem should repeat itself.