Summary: | Web Inspector: replace `featureGuard` and `availability` with a combined `condition` that accepts any macro | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | annulen, bburg, cgarcia, ews-watchlist, glenn, gyuyoung.kim, hi, inspector-bugzilla-changes, jbedard, joepeck, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, timothy, tzagallo, webkit-bug-importer | ||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
Version: | WebKit Local Build | ||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=227345 | ||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||
Bug Blocks: | 212436, 212494, 212497 | ||||||||||||||||||||||||
Attachments: |
|
Description
Devin Rousso
2020-04-04 19:46:10 PDT
Created attachment 395472 [details]
[Patch] WIP
Because we use macros in 'InspectorBackendCommands.js' too, we need to preprocess it. I've managed to get it working with `make`, but it also isn't nicely formatted (lots of extra newlines). I need to get CMake working too.
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Comment on attachment 395472 [details] [Patch] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=395472&action=review > Source/JavaScriptCore/DerivedSources.make:319 Use unifdef -B and you will not need the perl. Created attachment 399502 [details]
[Patch] WIP
The changes I've made to Source/JavaScriptCore/DerivedSources.make are working for me, but I think I still need to fix Sources/JavaScriptCore/CMakeLists.txt
Created attachment 399504 [details]
[Patch] WIP
fix some miscellaneous build issues
Created attachment 399507 [details]
[Patch] WIP
oops it should be `ENABLE` not `HAVE` :P
Created attachment 399526 [details]
[Patch] WIP
fix tests
Created attachment 399563 [details]
[Patch] WIP
attempt for CMake
Created attachment 399975 [details]
[Patch] WIP
Created attachment 399996 [details]
[Patch] WIP
Created attachment 400008 [details]
Patch
Created attachment 400009 [details]
Patch
rebase
Comment on attachment 400009 [details]
Patch
r=me
Committed r262203: <https://trac.webkit.org/changeset/262203> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400009 [details]. Comment on attachment 400009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400009&action=review > Source/WebInspectorUI/CMakeLists.txt:52 > + InspectorBackendCommands This caused the inspector to be copied for every incremental build, see bug #227345 |