Bug 212494 - Web Inspector: add missing condition guards when generating objc protocol files
Summary: Web Inspector: add missing condition guards when generating objc protocol files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 210014
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-28 15:05 PDT by Devin Rousso
Modified: 2020-05-28 15:45 PDT (History)
12 users (show)

See Also:


Attachments
Patch (30.22 KB, patch)
2020-05-28 15:12 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-05-28 15:05:16 PDT
fix internal build failures
Comment 1 Devin Rousso 2020-05-28 15:12:56 PDT
Created attachment 400513 [details]
Patch
Comment 2 EWS Watchlist 2020-05-28 15:13:58 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 EWS 2020-05-28 15:44:44 PDT
Committed r262266: <https://trac.webkit.org/changeset/262266>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400513 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-28 15:45:20 PDT
<rdar://problem/63735824>