Bug 209996

Summary: Additional sanity checks in compareAnimationsByCompositeOrder()
Product: WebKit Reporter: Doug Kelly <dougk>
Component: AnimationsAssignee: Doug Kelly <dougk>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ggaren, graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Doug Kelly
Reported 2020-04-03 18:28:45 PDT
compareAnimationsByCompositeOrder() is used by std::sort which requires strict weak ordering. Add additional checks to ensure strict weak ordering is maintained. <rdar://problem/60199826>
Attachments
Patch (3.00 KB, patch)
2020-04-03 18:37 PDT, Doug Kelly 		no flags
DetailsFormatted DiffDiff
Patch (6.14 KB, patch)
2020-04-04 09:13 PDT, Doug Kelly 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Doug Kelly
Comment 1 2020-04-03 18:37:15 PDT
Created attachment 395427 [details] Patch
Geoffrey Garen
Comment 2 2020-04-04 08:27:31 PDT
Comment on attachment 395427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395427&action=review > Source/WebCore/animation/WebAnimationUtilities.cpp:87 > + } else > + return !rhsIsCSSAnimation; If you put this code first as an early return, you can eliminate the nested indentation for twenty lines of code above. I think that would read more clearly.
Doug Kelly
Comment 3 2020-04-04 08:35:54 PDT
Comment on attachment 395427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395427&action=review >> Source/WebCore/animation/WebAnimationUtilities.cpp:87 >> + return !rhsIsCSSAnimation; > > If you put this code first as an early return, you can eliminate the nested indentation for twenty lines of code above. I think that would read more clearly. I think that makes sense... it can probably apply to the same case above, too. :)
Doug Kelly
Comment 4 2020-04-04 09:13:55 PDT
Created attachment 395450 [details] Patch
Geoffrey Garen
Comment 5 2020-04-04 15:04:25 PDT
Comment on attachment 395450 [details] Patch r=me
EWS
Comment 6 2020-04-04 15:39:23 PDT
Committed r259538: <https://trac.webkit.org/changeset/259538> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395450 [details].
Note You need to log in before you can comment on or make changes to this bug.