Bug 209994 – [iOS] WebPageProxy::didCommitLoadForFrame should not crash with null or empty `mimeType` parameter

• Component: WebKit2
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

WebPageProxy::didCommitLoadForFrame should validate its `mimeType` parameter.

<rdar://problem/60068700>

[David Kilzer (:ddkilzer)]

Created attachment 395423 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Looks like the mimeType parameter can be nil (nullptr) with these tests:

TestWebKitAPI.WebKit.PendingAPIRequestURL
TestWebKitAPI.WebKit.LoadDataWithNilMIMEType

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #2)
> Looks like the mimeType parameter can be nil (nullptr) with these tests:
> 
> TestWebKitAPI.WebKit.PendingAPIRequestURL
> TestWebKitAPI.WebKit.LoadDataWithNilMIMEType

The api-ios bot only shows this test failing:

TestWebKitAPI.WebKit.LoadDataWithNilMIMEType

[David Kilzer (:ddkilzer)]

Created attachment 395751 [details]
Patch v2

[EWS]

Committed r259729: <https://trac.webkit.org/changeset/259729>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395751 [details].

[Darin Adler]

Comment on attachment 395751 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=395751&action=review

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:283
> +    UNUSED_PARAM(mimeType);
> +    UNUSED_PARAM(useCustomContentProvider);

Better to omit or comment out the argument names since that will give an error if we actually do use one, whereas if we use UNUSED_PARAM will keep compiling.

[David Kilzer (:ddkilzer)]

(In reply to Darin Adler from comment #6)
> Comment on attachment 395751 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395751&action=review
> 
> > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:283
> > +    UNUSED_PARAM(mimeType);
> > +    UNUSED_PARAM(useCustomContentProvider);
> 
> Better to omit or comment out the argument names since that will give an
> error if we actually do use one, whereas if we use UNUSED_PARAM will keep
> compiling.

Committed r259750: <https://trac.webkit.org/changeset/259750>