Bug 209984

Summary: [iOS] Simplify ProcessAssertion class in preparation for switch to RunningBoard
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, darin, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210049
Bug Depends on:    
Bug Blocks: 209990    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-04-03 13:54:38 PDT
Simplify ProcessAssertion class in preparation for switch to RunningBoard. There is a slight mismatch between the way BKS and RunningBoard process assertion API. This refactoring makes it so that we can use the same ProcessAssertion class in WebKit to work with either BKS or RunningBoard. Support for RunningBoard will come later.
Attachments
Patch (38.52 KB, patch)
2020-04-03 14:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-04-03 13:54:52 PDT
<rdar://problem/61273941>
Chris Dumez
Comment 2 2020-04-03 14:07:41 PDT
Created attachment 395409 [details] Patch
Darin Adler
Comment 3 2020-04-04 16:40:15 PDT
Comment on attachment 395409 [details] Patch If reasons are always C++ literals, why store them in WTF::String? We could just store as const char* or maybe even as WTF::ASCIILiteral.
EWS
Comment 4 2020-04-04 17:03:52 PDT
Committed r259540: <https://trac.webkit.org/changeset/259540> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395409 [details].
Chris Dumez
Comment 5 2020-04-06 08:27:52 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 395409 [details] > Patch > > If reasons are always C++ literals, why store them in WTF::String? We could > just store as const char* or maybe even as WTF::ASCIILiteral. Ok, will follow-up in https://bugs.webkit.org/show_bug.cgi?id=210049.
Note You need to log in before you can comment on or make changes to this bug.