Bug 209976

Summary: ASSERTION FAILED: objectStoreInfo in SQLiteIDBBackingStore::getRecord
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: WebCore Misc.Assignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, ews-watchlist, ggaren, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Sihui Liu 2020-04-03 10:39:40 PDT
Normally this assertion will not be hit, but we see cases where objectStoreInfo is null as in the radar. 
So I tried to modify the code a bit by returning error at specific places, and successfully got the assertion failure. Therefore, theoretically it's possible that SQLiteIDBBackingStore does not have requested ObjectStoreInfo in SQLiteIDBBackingStore::getRecord. Then we need to change this assertion to an error and make early return.
Comment 1 Sihui Liu 2020-04-03 10:40:04 PDT
<rdar://problem/55005363>
Comment 2 Sihui Liu 2020-04-03 10:45:39 PDT
Created attachment 395395 [details]
Patch
Comment 3 Geoffrey Garen 2020-04-03 11:56:19 PDT
Comment on attachment 395395 [details]
Patch

r=me
Comment 4 EWS 2020-04-03 15:56:03 PDT
Committed r259519: <https://trac.webkit.org/changeset/259519>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395395 [details].