Bug 209976 - ASSERTION FAILED: objectStoreInfo in SQLiteIDBBackingStore::getRecord
Summary: ASSERTION FAILED: objectStoreInfo in SQLiteIDBBackingStore::getRecord
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-03 10:39 PDT by Sihui Liu
Modified: 2020-04-03 15:56 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2020-04-03 10:45 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-04-03 10:39:40 PDT 
Normally this assertion will not be hit, but we see cases where objectStoreInfo is null as in the radar. 
So I tried to modify the code a bit by returning error at specific places, and successfully got the assertion failure. Therefore, theoretically it's possible that SQLiteIDBBackingStore does not have requested ObjectStoreInfo in SQLiteIDBBackingStore::getRecord. Then we need to change this assertion to an error and make early return.
Comment 1 Sihui Liu 2020-04-03 10:40:04 PDT 
<rdar://problem/55005363>
Comment 2 Sihui Liu 2020-04-03 10:45:39 PDT 
Created attachment 395395 [details]
Patch
Comment 3 Geoffrey Garen 2020-04-03 11:56:19 PDT 
Comment on attachment 395395 [details]
Patch

r=me
Comment 4 EWS 2020-04-03 15:56:03 PDT 
Committed r259519: <https://trac.webkit.org/changeset/259519>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395395 [details].