Bug 209954

Summary: [Flatpak SDK] Create platform/Release directory only when build-webkit is called
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 209960    
Attachments:
Description Flags
Patch
none
Patch none

Diego Pino
Reported 2020-04-03 00:51:18 PDT
[WPE] Pass --wpe argument to update-webkit-flatpak
Attachments
Patch (1.22 KB, patch)
2020-04-03 00:51 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2020-04-03 02:35 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-04-03 00:51:33 PDT
Created attachment 395355 [details] Patch
Diego Pino
Comment 2 2020-04-03 00:57:57 PDT
On calling `Tools/Scripts/update-webkitwpe-libs`, script `update-webkit-flatpak` is called without platform name (--wpe), taking GTK as default. As a result, flatpak argument '--bind-mount=/app/webkit/WebKitBuild/Release' points to '../WebKitBuild/GTK/Release', when it should point to '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK' folder is created.
Philippe Normand
Comment 3 2020-04-03 01:09:05 PDT
This shouldn't be necessary, because the same SDK is used for both GTK and WPE.
Philippe Normand
Comment 4 2020-04-03 01:36:27 PDT
(In reply to Diego Pino from comment #2) > On calling `Tools/Scripts/update-webkitwpe-libs`, script > `update-webkit-flatpak` is called without platform name (--wpe), taking GTK > as default. As a result, flatpak argument > '--bind-mount=/app/webkit/WebKitBuild/Release' points to > '../WebKitBuild/GTK/Release', when it should point to > '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK' > folder is created. Regarding this, perhaps we can simply avoid to mkdir the build directory unless we're being called by build-webkit.
Diego Pino
Comment 5 2020-04-03 02:35:49 PDT
Created attachment 395360 [details] Patch
EWS
Comment 6 2020-04-03 04:10:43 PDT
Committed r259453: <https://trac.webkit.org/changeset/259453> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395360 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-03 04:11:16 PDT
<rdar://problem/61253950>
Note You need to log in before you can comment on or make changes to this bug.