Summary: | [Flatpak SDK] Create platform/Release directory only when build-webkit is called | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||
Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | pnormand, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 209960 | ||||||||
Attachments: |
|
Description
Diego Pino
2020-04-03 00:51:18 PDT
Created attachment 395355 [details]
Patch
On calling `Tools/Scripts/update-webkitwpe-libs`, script `update-webkit-flatpak` is called without platform name (--wpe), taking GTK as default. As a result, flatpak argument '--bind-mount=/app/webkit/WebKitBuild/Release' points to '../WebKitBuild/GTK/Release', when it should point to '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK' folder is created. This shouldn't be necessary, because the same SDK is used for both GTK and WPE. (In reply to Diego Pino from comment #2) > On calling `Tools/Scripts/update-webkitwpe-libs`, script > `update-webkit-flatpak` is called without platform name (--wpe), taking GTK > as default. As a result, flatpak argument > '--bind-mount=/app/webkit/WebKitBuild/Release' points to > '../WebKitBuild/GTK/Release', when it should point to > '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK' > folder is created. Regarding this, perhaps we can simply avoid to mkdir the build directory unless we're being called by build-webkit. Created attachment 395360 [details]
Patch
Committed r259453: <https://trac.webkit.org/changeset/259453> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395360 [details]. |