Summary: | HTMLVideoElement width and height attributes are now unsigned | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Eric Carlson
2008-09-22 09:21:21 PDT
Created attachment 23653 [details]
proposed patch
Comment on attachment 23653 [details]
proposed patch
You need to change the c++ files to return unsigned as well.
r-
Created attachment 23656 [details]
Revised patch
Update c++ files to take and return unsigned, make videoWidth and videoHeight return unsigned to match idl.
Comment on attachment 23656 [details]
Revised patch
+ unsigned w = getAttribute(widthAttr).toInt(&ok);
+ unsigned h = getAttribute(heightAttr).toInt(&ok);
These need to use toUInt().
Created attachment 23801 [details]
Revised patch
Convert all unsigned attributes with toUInt().
Comment on attachment 23801 [details]
Revised patch
Woot! r=me
Third time was a charm. Committed as revision 37030. |