Bug 20993

Summary:

Array.push/pop need optimized cases for JSArray

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

JavaScriptCore

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
work in progress	none
patch	sam: review+

Darin Adler

Reported 2008-09-22 09:15:02 PDT

The deltablue benchmark uses Array.push/pop a lot, and we need faster versions.

Attachments
work in progress (5.49 KB, patch) 2008-09-22 09:15 PDT, Darin Adler	no flags	Details Formatted Diff Diff
patch (6.59 KB, patch) 2008-09-22 13:51 PDT, Darin Adler	sam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2008-09-22 09:15:38 PDT

Created attachment 23652 [details] work in progress Seems to be correct and fast on deltablue, but slows down SunSpider for some reason.

Darin Adler

Comment 2 2008-09-22 13:01:12 PDT

Maciej tested it and said that it didn't slow SunSpider down for him. Hooray!

Darin Adler

Comment 3 2008-09-22 13:51:47 PDT

Darin Adler

Comment 4 2008-09-22 14:05:17 PDT

Note You need to log in before you can comment on or make changes to this bug.