Bug 209922

Summary: Move Intl tests from LayoutTests to JSTests
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: JavaScriptCoreAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210085
Attachments:
Description Flags
Patch
none
Patch none

Ross Kirsling
Reported 2020-04-02 13:22:43 PDT
Move Intl API tests from LayoutTests to JSTests
Attachments
Patch (655.43 KB, patch)
2020-04-02 13:34 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (655.47 KB, patch)
2020-04-02 14:50 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-04-02 13:34:11 PDT
Created attachment 395292 [details] Patch
Ross Kirsling
Comment 2 2020-04-02 13:39:57 PDT
Sorry if this is a bit tricky to review due to updating the assertion style of the test cases. I do recommend that we migrate tests from LayoutTests/js to JSTests/stress any time we're bitten by them as a general practice, but I might not necessarily recommend taking the time to update the assertion style like this in the future.
Ross Kirsling
Comment 3 2020-04-02 14:36:39 PDT
Grr, I tried to relax the skips a bit, but apparently that part will need to wait until after bug 209694.
Ross Kirsling
Comment 4 2020-04-02 14:50:07 PDT
Created attachment 395304 [details] Patch
Yusuke Suzuki
Comment 5 2020-04-03 03:23:17 PDT
Comment on attachment 395304 [details] Patch r=me
EWS
Comment 6 2020-04-03 11:34:58 PDT
Committed r259480: <https://trac.webkit.org/changeset/259480> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395304 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-03 11:35:16 PDT
<rdar://problem/61267995>
Note You need to log in before you can comment on or make changes to this bug.