Bug 209894

Summary: HTMLFormElement should use WeakPtr to keep track of its associated elements
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FormsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, koivisto, mifenton, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Uses WeakPtr wenson_hsieh: review+

Ryosuke Niwa
Reported 2020-04-01 22:08:23 PDT
HTMLFormElement currently has raw pointers to FormAssociatedElement. Replace them with WeakPtr.
Attachments
Uses WeakPtr (22.62 KB, patch)
2020-04-01 22:19 PDT, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2020-04-01 22:19:50 PDT
Created attachment 395244 [details] Uses WeakPtr
Ryosuke Niwa
Comment 2 2020-04-02 09:50:23 PDT
Ping reviewers.
Wenson Hsieh
Comment 3 2020-04-02 09:55:44 PDT
Comment on attachment 395244 [details] Uses WeakPtr View in context: https://bugs.webkit.org/attachment.cgi?id=395244&action=review > Source/WebCore/html/HTMLFormElement.cpp:890 > + Nit - extra newline here.
Ryosuke Niwa
Comment 4 2020-04-02 11:04:14 PDT
Committed r259393: <https://trac.webkit.org/changeset/259393>
Radar WebKit Bug Importer
Comment 5 2020-04-02 11:05:16 PDT
<rdar://problem/61216706>
Ryosuke Niwa
Comment 6 2020-04-02 11:07:29 PDT
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 395244 [details] > Uses WeakPtr > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395244&action=review > > > Source/WebCore/html/HTMLFormElement.cpp:890 > > + > > Nit - extra newline here. Oh oops, I missed that.
Ryosuke Niwa
Comment 7 2020-04-02 11:08:22 PDT
Fixed that in https://trac.webkit.org/changeset/259394
Note You need to log in before you can comment on or make changes to this bug.