Summary: | Web Inspector: focus outline of scope bar is clipped | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | inspector-bugzilla-changes, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Created attachment 395200 [details]
Patch
Comment on attachment 395200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395200&action=review > Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:-28 > - overflow: hidden; Do we know why overflow: hidden was here to begin with? Was it to prevent bad overflow when there is not enough room? Comment on attachment 395200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395200&action=review >> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:-28 >> - overflow: hidden; > > Do we know why overflow: hidden was here to begin with? Was it to prevent bad overflow when there is not enough room? I looked at all cases where the scope bar is used (`new WI.ScopeBar`) and haven't found any issues with removing `overflow: hidden`. Comment on attachment 395200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395200&action=review >>> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:-28 >>> - overflow: hidden; >> >> Do we know why overflow: hidden was here to begin with? Was it to prevent bad overflow when there is not enough room? > > I looked at all cases where the scope bar is used (`new WI.ScopeBar`) and haven't found any issues with removing `overflow: hidden`. To answer your 1st question, I don't know why `overflow: hidden` is here. `git blame` shows that this line was added in 2013 when Web Inspector was open sourced again. Committed r259666: <https://trac.webkit.org/changeset/259666> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395200 [details]. |
Created attachment 395198 [details] [Image] Bug Affected areas: In Sources tab, left sidebar: "By Type" and "By Path". Storage tab, left sidebar: "All Storage" and "Application Cache"