Bug 209857

Summary: Add HEVC support in GPU Process for WebRTC
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: agouaillard, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-04-01 08:11:03 PDT
Add HEVC support in GPU Process for WebRTC
Attachments
Patch (239.42 KB, patch)
2020-04-01 08:13 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (240.48 KB, patch)
2020-04-01 09:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (67.40 KB, patch)
2020-04-03 05:31 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (67.51 KB, patch)
2020-04-06 00:11 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-04-01 08:13:33 PDT
Created attachment 395168 [details] Patch
youenn fablet
Comment 2 2020-04-01 09:23:51 PDT
Created attachment 395175 [details] Patch
youenn fablet
Comment 3 2020-04-03 05:31:44 PDT
Created attachment 395367 [details] Patch
EWS
Comment 4 2020-04-03 07:34:23 PDT
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.
Eric Carlson
Comment 5 2020-04-03 12:21:49 PDT
Comment on attachment 395367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395367&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153 > + supported_formats.push_back(SdpVideoFormat { "H264" }); > + supported_formats.push_back(SdpVideoFormat { "VP8" }); Should this add "H265" as well?
youenn fablet
Comment 6 2020-04-06 00:10:57 PDT
(In reply to Eric Carlson from comment #5) > Comment on attachment 395367 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395367&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153 > > + supported_formats.push_back(SdpVideoFormat { "H264" }); > > + supported_formats.push_back(SdpVideoFormat { "VP8" }); > > Should this add "H265" as well? Thanks, will fix it. Looking at libwebrtc code, I do not really see where it is used on the decoder side (it is used on the encoder side though).
youenn fablet
Comment 7 2020-04-06 00:11:28 PDT
Created attachment 395551 [details] Patch for landing
EWS
Comment 8 2020-04-06 02:04:50 PDT
Found 1 new test failure: storage/indexeddb/value-cursor-cycle.html
EWS
Comment 9 2020-04-06 02:57:32 PDT
Committed r259568: <https://trac.webkit.org/changeset/259568> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395551 [details].
Radar WebKit Bug Importer
Comment 10 2020-04-06 02:58:14 PDT
<rdar://problem/61335983>
Note You need to log in before you can comment on or make changes to this bug.