Summary: | Add HEVC support in GPU Process for WebRTC | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | agouaillard, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2020-04-01 08:11:03 PDT
Created attachment 395168 [details]
Patch
Created attachment 395175 [details]
Patch
Created attachment 395367 [details]
Patch
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!. Comment on attachment 395367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395367&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153 > + supported_formats.push_back(SdpVideoFormat { "H264" }); > + supported_formats.push_back(SdpVideoFormat { "VP8" }); Should this add "H265" as well? (In reply to Eric Carlson from comment #5) > Comment on attachment 395367 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395367&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153 > > + supported_formats.push_back(SdpVideoFormat { "H264" }); > > + supported_formats.push_back(SdpVideoFormat { "VP8" }); > > Should this add "H265" as well? Thanks, will fix it. Looking at libwebrtc code, I do not really see where it is used on the decoder side (it is used on the encoder side though). Created attachment 395551 [details]
Patch for landing
Found 1 new test failure: storage/indexeddb/value-cursor-cycle.html Committed r259568: <https://trac.webkit.org/changeset/259568> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395551 [details]. |