Bug 209826

Summary: Make FrameView and Frame TextStream-loggable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2020-03-31 12:25:18 PDT
Make FrameView and Frame TextStream-loggable
Attachments
Patch (4.15 KB, patch)
2020-03-31 12:26 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-03-31 12:26:29 PDT
Created attachment 395078 [details] Patch
Darin Adler
Comment 2 2020-03-31 12:34:53 PDT
Comment on attachment 395078 [details] Patch I totally want to reverse the ValueOrNull thing for TextStream. By default pointers should log "value of pointed to thing or null" and we should have a function you can call on a pointer to make it instead log a hex pointer value. Also, if we keep ValueOrNull we can leave off the "OrNull" part. The real question is whether to log the pointer or the pointed-to thing. Not sure the word "value" is unambiguous about that, but it’s cool.
EWS
Comment 3 2020-03-31 19:49:38 PDT
Committed r259335: <https://trac.webkit.org/changeset/259335> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395078 [details].
Radar WebKit Bug Importer
Comment 4 2020-03-31 19:50:15 PDT
<rdar://problem/61137062>
Note You need to log in before you can comment on or make changes to this bug.