Bug 209808

Summary: Support resolution of IPv6 STUN/TURN addresses
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, cgarcia, eric.carlson, ews-watchlist, gustavo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description youenn fablet 2020-03-31 07:22:17 PDT 
Support resolution of IPv6 STUN/TURN addresses
Comment 1 Radar WebKit Bug Importer 2020-03-31 07:42:03 PDT 
<rdar://problem/61106625>
Comment 2 youenn fablet 2020-03-31 07:44:13 PDT 
Created attachment 395036 [details]
Patch
Comment 3 youenn fablet 2020-03-31 08:12:11 PDT 
Created attachment 395041 [details]
Patch
Comment 4 youenn fablet 2020-03-31 09:32:03 PDT 
Comment on attachment 395041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395041&action=review

> Source/WebCore/platform/network/DNS.h:54
> +    struct sockaddr_in6 m_address;

It might be better to use a Variant<inet, inet6>, I'll switch to that before landing.
Comment 5 youenn fablet 2020-04-01 00:04:46 PDT 
Created attachment 395135 [details]
Patch for landing
Comment 6 youenn fablet 2020-04-01 00:37:42 PDT 
Created attachment 395138 [details]
Patch for landing
Comment 7 youenn fablet 2020-04-01 00:58:05 PDT 
Created attachment 395140 [details]
Patch for landing
Comment 8 youenn fablet 2020-04-01 01:08:54 PDT 
Created attachment 395141 [details]
Patch for landing
Comment 9 EWS 2020-04-01 01:14:14 PDT 
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 10 youenn fablet 2020-04-01 01:23:45 PDT 
Created attachment 395146 [details]
Patch for landing
Comment 11 youenn fablet 2020-04-01 01:24:51 PDT 
Added a FIXME for SOUP backend to handle multiple addresses, with potentially both IPv6 and IPv4 addresses.
Comment 12 EWS 2020-04-01 02:08:32 PDT 
Committed r259338: <https://trac.webkit.org/changeset/259338>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395146 [details].