Bug 209748

Summary: WebKit should take a foreground assertion for offscreen loads when the app is foreground
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209759
Bug Depends on: 209759    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Chris Dumez
Reported 2020-03-30 09:40:39 PDT
WebKit should take a foreground assertion for offscreen loads when the app is foreground.
Attachments
Patch (1.44 KB, patch)
2020-03-30 09:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2020-03-30 16:24 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-03-30 09:40:58 PDT
<rdar://problem/59169812>
Chris Dumez
Comment 2 2020-03-30 09:41:35 PDT
Created attachment 394927 [details] Patch
Geoffrey Garen
Comment 3 2020-03-30 10:53:46 PDT
Comment on attachment 394927 [details] Patch r=me
EWS
Comment 4 2020-03-30 11:02:59 PDT
Committed r259211: <https://trac.webkit.org/changeset/259211> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394927 [details].
Ryan Haddad
Comment 5 2020-03-30 15:20:09 PDT
(In reply to EWS from comment #4) > Committed r259211: <https://trac.webkit.org/changeset/259211> Seeing hundreds of API tests assert after this change: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/builds/2865/steps/run-api-tests/logs/stdio
Ryan Haddad
Comment 6 2020-03-30 15:22:52 PDT
Reverted r259211 for reason: Caused API test assertion failures on iOS Committed r259237: <https://trac.webkit.org/changeset/259237>
Chris Dumez
Comment 7 2020-03-30 16:24:29 PDT
Created attachment 394982 [details] Patch
EWS
Comment 8 2020-03-30 16:42:59 PDT
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Chris Dumez
Comment 9 2020-03-30 16:45:00 PDT
Committed r259243: <https://trac.webkit.org/changeset/259243>
Note You need to log in before you can comment on or make changes to this bug.