Bug 209747

Summary: [Cocoa] Minor code cleanup around WebDataListSuggestionsDropdown
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2020-03-30 09:01:11 PDT
- Make _dropdown a weak pointer instead of a raw pointer. - Make -showSuggestionsDropdown: take a reference instead of a pointer.
Attachments
Patch (8.18 KB, patch)
2020-03-30 09:04 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-03-30 09:04:31 PDT
Created attachment 394923 [details] Patch
Wenson Hsieh
Comment 2 2020-03-30 10:26:12 PDT
Comment on attachment 394923 [details] Patch Thanks for the review!
EWS
Comment 3 2020-03-30 10:30:06 PDT
Committed r259207: <https://trac.webkit.org/changeset/259207> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394923 [details].
Note You need to log in before you can comment on or make changes to this bug.