Bug 209669

Summary:

[AutoSizing] Bring back the old auto-sizing code as a deprecated codepath for compatibility reasons

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Layout and Rendering

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, darin, graouts, simon.fraser, thorton, timothy, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196743

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Antoine Quint

Reported 2020-03-27 11:17:27 PDT

[AutoSizing] Bring back the old auto-sizing code as a deprecated codepath for compatibility reasons

Attachments
Patch (35.46 KB, patch) 2020-03-27 11:25 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (35.66 KB, patch) 2020-03-27 13:18 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (35.77 KB, patch) 2020-03-28 02:36 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (35.62 KB, patch) 2020-03-28 03:06 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (35.63 KB, patch) 2020-03-28 03:30 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (39.44 KB, patch) 2020-03-29 10:59 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (42.00 KB, patch) 2020-03-29 12:35 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (42.02 KB, patch) 2020-03-29 12:37 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (43.36 KB, patch) 2020-03-29 13:43 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2020-03-27 11:25:16 PDT

Created attachment 394735 [details] Patch

zalan

Comment 2 2020-03-27 11:33:43 PDT

Comment on attachment 394735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394735&action=review > Source/WebCore/page/FrameViewLayoutContext.cpp:236 > view().autoSizeIfEnabled(); > + view().legacyAutoSizeIfEnabled(); Can we instead move it to autoSizeIfEnabled and branch in there for legacy behavior?

Simon Fraser (smfr)

Comment 3 2020-03-27 12:39:02 PDT

Please include the radar.

Simon Fraser (smfr)

Comment 4 2020-03-27 12:41:46 PDT

Can we also rename to avoid confusion with text autosizing.

Antoine Quint

Comment 5 2020-03-27 13:18:30 PDT

Created attachment 394750 [details] Patch

zalan

Comment 6 2020-03-27 14:21:41 PDT

FrameView&co looks good!

Antoine Quint

Comment 7 2020-03-28 02:36:26 PDT

Created attachment 394799 [details] Patch

Antoine Quint

Comment 8 2020-03-28 03:06:33 PDT

Created attachment 394803 [details] Patch

Antoine Quint

Comment 9 2020-03-28 03:30:14 PDT

Created attachment 394809 [details] Patch

Simon Fraser (smfr)

Comment 10 2020-03-29 08:35:32 PDT

Comment on attachment 394809 [details] Patch Can we call this something other than "deprecated" auto-size mode? How does it differ from the non-deprecated one?

zalan

Comment 11 2020-03-29 08:39:28 PDT

(In reply to Simon Fraser (smfr) from comment #10) > Comment on attachment 394809 [details] > Patch > > Can we call this something other than "deprecated" auto-size mode? How does > it differ from the non-deprecated one? It's very different. The old auto-size flattens the content, the new one does not. The current auto-size code pretty much just lays out the content with a fixed constraint and reports the intrinsic size.

Darin Adler

Comment 12 2020-03-29 08:46:33 PDT

Comment on attachment 394809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394809&action=review This looks OK but I’m very surprised that we are not adding any tests for this > Source/WebCore/page/FrameView.h:710 > + enum class AutoSizeMode : uint8_t { Default, Deprecated }; Could use bool instead of uint8_t. Do we know if one is superior?

Antoine Quint

Comment 13 2020-03-29 10:59:26 PDT

Created attachment 394870 [details] Patch

Antoine Quint

Comment 14 2020-03-29 12:35:20 PDT

Created attachment 394872 [details] Patch

Antoine Quint

Comment 15 2020-03-29 12:37:29 PDT

Created attachment 394874 [details] Patch

Antoine Quint

Comment 16 2020-03-29 13:43:17 PDT

Created attachment 394876 [details] Patch