Bug 209663

Summary: Add missing scope release to DataView's buffer getter
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, jacob_uphoff, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Miller
Reported 2020-03-27 10:42:13 PDT
Add missing scope release to DataView's buffer getter
Attachments
Patch (1.56 KB, patch)
2020-03-27 10:42 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-03-27 10:42:27 PDT
Created attachment 394729 [details] Patch
Darin Adler
Comment 2 2020-03-27 10:56:14 PDT
Comment on attachment 394729 [details] Patch I want to know how to write correct patches in the futures. How do we notice in tests if we get something like this wrong?
EWS
Comment 3 2020-03-27 11:06:05 PDT
Committed r259127: <https://trac.webkit.org/changeset/259127> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394729 [details].
Radar WebKit Bug Importer
Comment 4 2020-03-27 11:07:16 PDT
<rdar://problem/60975866>
Keith Miller
Comment 5 2020-03-27 11:08:38 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 394729 [details] > Patch > > I want to know how to write correct patches in the futures. How do we notice > in tests if we get something like this wrong? You'll see these if you set the JSC_validateExceptionChecks environment variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks, though. That said, I think only JSC runs tests with this option since WebCore has so many false positives i.e not releasing the scope before tail-calling like here. At some point we should sit down and fix those...
Keith Miller
Comment 6 2020-03-27 11:09:27 PDT
(In reply to Keith Miller from comment #5) > (In reply to Darin Adler from comment #2) > > Comment on attachment 394729 [details] > > Patch > > > > I want to know how to write correct patches in the futures. How do we notice > > in tests if we get something like this wrong? > > You'll see these if you set the JSC_validateExceptionChecks environment > variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks, > though. You'll also need a Debug or Release-Assert build.
Keith Miller
Comment 7 2020-03-27 11:39:01 PDT
*** Bug 209658 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.