| Summary: | Add missing scope release to DataView's buffer getter | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, ews-watchlist, jacob_uphoff, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2020-03-27 10:42:13 PDT
Created attachment 394729 [details]
Patch
Comment on attachment 394729 [details]
Patch
I want to know how to write correct patches in the futures. How do we notice in tests if we get something like this wrong?
Committed r259127: <https://trac.webkit.org/changeset/259127> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394729 [details]. (In reply to Darin Adler from comment #2) > Comment on attachment 394729 [details] > Patch > > I want to know how to write correct patches in the futures. How do we notice > in tests if we get something like this wrong? You'll see these if you set the JSC_validateExceptionChecks environment variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks, though. That said, I think only JSC runs tests with this option since WebCore has so many false positives i.e not releasing the scope before tail-calling like here. At some point we should sit down and fix those... (In reply to Keith Miller from comment #5) > (In reply to Darin Adler from comment #2) > > Comment on attachment 394729 [details] > > Patch > > > > I want to know how to write correct patches in the futures. How do we notice > > in tests if we get something like this wrong? > > You'll see these if you set the JSC_validateExceptionChecks environment > variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks, > though. You'll also need a Debug or Release-Assert build. *** Bug 209658 has been marked as a duplicate of this bug. *** |