Bug 20965

Summary: Refactor HTMLImageLoader, share code with SVGImageLoader
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Initial patch eric: review+

Nikolas Zimmermann
Reported 2008-09-20 11:42:37 PDT
HTMLImageLoader should be copied to loader/ImageLoader, and should serve as base class for both HTMLImageLoader & SVGImageLoader.
Attachments
Initial patch (37.71 KB, patch)
2008-09-20 12:54 PDT, Nikolas Zimmermann 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2008-09-20 12:54:48 PDT
Created attachment 23610 [details] Initial patch
Eric Seidel (no email)
Comment 2 2008-09-20 13:14:29 PDT
Comment on attachment 23610 [details] Initial patch I assume you ran the layout tests. Looks sane enough. Difficult to do a very detailed review on this code move.
Nikolas Zimmermann
Comment 3 2008-09-20 13:20:13 PDT
Landed in r36712.
Note You need to log in before you can comment on or make changes to this bug.