Summary: | [Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Tools / Tests | Assignee: | Philippe Normand <pnormand> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, bugs-noreply, clopez, tsaunier, webkit-bug-importer, zan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2020-03-27 03:34:22 PDT
Generally speaking, I think webkit-flatpak has too many, redundant, options... Maybe we can remove most of those? For instance, --tests doesn't seem necessary as we should use run-webkit-tests directly. Dunno. Just some thoughts :) Created attachment 395170 [details]
Patch
Speaking for myself I use none of those.. I run the scripts (run-minibrowser, run-webkit-tests, etc) directly and I expect those scripts to work automatically with flatpak if I have previously built the third-party libraries with flatpak. But I don't know if somebody else uses this :? To my knowledge Thibault was the only one using webkit-flatpak directly. I use it occasionally but only to get in the sandbox or run gdb. I also use the existing scripts whenever possible. (In reply to Philippe Normand from comment #4) > To my knowledge Thibault was the only one using webkit-flatpak directly. I > use it occasionally but only to get in the sandbox or run gdb. I also use > the existing scripts whenever possible. I have used “webkit-flatpak” directly sometimes, most of the time it's nicer to use the existing scripts, but having the escape hatch to do things “by hand” with the Flatpak environment is handy — the same way as having the “jhbuild-wrapper” script has been useful sometimes. Which webkit-flatpak options do you use? This patch doesn't remove all of them :) Committed r259451: <https://trac.webkit.org/changeset/259451> |