Bug 209647

Summary: [WPE] Unnecessary gl synchronization when using an OpenMAX video decoder and GLES2
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WPE WebKitAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Miguel Gomez
Reported 2020-03-27 03:16:41 PDT
On platforms that use an OpenMAX video decoder (like the rpi3) and GLES2, the call to gst_gl_sync_meta_wait_cpu() (which is internally translated into a glFinish call), causes unnecessary waits when trying to the video frame using gstreamer-gl, reducing the framerate. On these platforms the call to gst_gl_sync_meta_wait_cpu() can be omitted cause we know that OpenGL will ensure that the video frame will be ready when we want to draw it.
Attachments
Patch (3.15 KB, patch)
2020-03-27 03:39 PDT, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2020-03-27 03:39:02 PDT
Created attachment 394715 [details] Patch
Adrian Perez
Comment 2 2020-03-27 05:45:12 PDT
Minor nit: The bug tile should have “[GStreamer]” instead of “[WPE]” 😉️
Xabier Rodríguez Calvar
Comment 3 2020-03-27 06:04:46 PDT
Comment on attachment 394715 [details] Patch I would have changed the name of the method to waitForCPUSyncIfNeeded
EWS
Comment 4 2020-03-27 06:14:06 PDT
Committed r259113: <https://trac.webkit.org/changeset/259113> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394715 [details].
Note You need to log in before you can comment on or make changes to this bug.