Bug 209606

Summary: IndexedDB: destroy WebIDBServer when session is removed in network process
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2020-03-26 10:29:05 PDT
Also perform necessary cleanup on WebIDBServer before deleting it.
Attachments
Patch (11.20 KB, patch)
2020-03-26 10:40 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.39 KB, patch)
2020-03-31 14:54 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2020-03-26 10:29:38 PDT
<rdar://problem/59310081>
Sihui Liu
Comment 2 2020-03-26 10:40:16 PDT
Created attachment 394624 [details] Patch
Geoffrey Garen
Comment 3 2020-03-27 09:09:36 PDT
Comment on attachment 394624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394624&action=review r=me > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:375 > +void WebIDBServer::destroy() Since this doesn't directly delete the object, I think a name like "close" or "invalidate" would be better.
Sihui Liu
Comment 4 2020-03-31 14:54:20 PDT
Created attachment 395094 [details] Patch for landing
EWS
Comment 5 2020-03-31 15:19:32 PDT
Committed r259316: <https://trac.webkit.org/changeset/259316> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395094 [details].
Note You need to log in before you can comment on or make changes to this bug.