Bug 209558

Summary:

[Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

New Bugs

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, jbedard, pnormand, webkit-bug-importer, zan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	zan: review+

Description Sergio Villar Senin 2020-03-25 13:20:15 PDT

[Flatpak] Pass all the arguments of build-webkit to webkit-flatpak

Comment 1 Sergio Villar Senin 2020-03-25 13:26:15 PDT

Created attachment 394537 [details]
Patch

Comment 2 Philippe Normand 2020-03-26 02:38:11 PDT

Comment on attachment 394537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394537&action=review

> Tools/Scripts/webkitdirs.pm:2100
> -    exec @command, argumentsForConfiguration(), "--command", @_, argumentsForConfiguration(), @ARGV or die;
> +    exec @command, argumentsForConfiguration(), @ARGV, "--command", @_, argumentsForConfiguration(), @ARGV or die;

run-minibrowser --gtk --help now show's webkit-flatpak help instead of MiniBrowser`s :(

Comment 3 Philippe Normand 2020-03-26 07:55:31 PDT

Created attachment 394609 [details]
Patch

Comment 4 Philippe Normand 2020-03-26 08:25:20 PDT

Committed r259045: <https://trac.webkit.org/changeset/259045>

Comment 5 Radar WebKit Bug Importer 2020-03-26 08:26:14 PDT

<rdar://problem/60920052>