Bug 209538

Summary: Bump boringssl version to M82
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, alex, annulen, ap, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, pnormand, ryuan.choi, sergio, tsaunier, vjaquez, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209878
Bug Depends on: 209602    
Bug Blocks:    
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
ews-feeder: commit-queue-
Patch for landing
none
Patch none

youenn fablet
Reported 2020-03-25 06:14:59 PDT
Bump boringssl version to M82
Attachments
Patch (25.82 MB, patch)
2020-03-25 06:25 PDT, youenn fablet 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (25.82 MB, patch)
2020-03-26 03:03 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (25.79 MB, patch)
2020-03-26 04:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (25.78 MB, patch)
2020-03-27 03:10 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-03-25 06:25:40 PDT
Created attachment 394485 [details] Patch
Eric Carlson
Comment 2 2020-03-25 09:49:05 PDT
Comment on attachment 394485 [details] Patch rs=me
youenn fablet
Comment 3 2020-03-26 03:03:38 PDT
Created attachment 394587 [details] Patch for landing
EWS
Comment 4 2020-03-26 03:53:55 PDT
commit-queue failed to commit attachment 394587 [details] to WebKit repository.
youenn fablet
Comment 5 2020-03-26 04:03:37 PDT
Created attachment 394592 [details] Patch for landing
EWS
Comment 6 2020-03-26 04:43:22 PDT
Committed r259042: <https://trac.webkit.org/changeset/259042> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394592 [details].
Radar WebKit Bug Importer
Comment 7 2020-03-26 04:44:27 PDT
<rdar://problem/60914881>
WebKit Commit Bot
Comment 8 2020-03-26 09:09:04 PDT
Re-opened since this is blocked by bug 209602
Alexey Proskuryakov
Comment 9 2020-03-26 10:52:45 PDT
Rolled back in http://trac.webkit.org/r259054 I noticed that the patch contained many changes without ChangeLogs, in WebCore and in LayoutTests. Seems like they were landed accidentally?
youenn fablet
Comment 10 2020-03-27 03:10:20 PDT
Created attachment 394714 [details] Patch
youenn fablet
Comment 11 2020-03-27 03:11:17 PDT
(In reply to Alexey Proskuryakov from comment #9) > Rolled back in http://trac.webkit.org/r259054 > > I noticed that the patch contained many changes without ChangeLogs, in > WebCore and in LayoutTests. Seems like they were landed accidentally? Right, I unexpectedly squashed these changes while doing a rebase. This causes the test issues.
EWS
Comment 12 2020-03-27 03:36:16 PDT
Committed r259111: <https://trac.webkit.org/changeset/259111> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394714 [details].
Aakash Jain
Comment 13 2020-03-27 10:05:43 PDT
(In reply to EWS from comment #12) > Committed r259111: <https://trac.webkit.org/changeset/259111> This seems to have broken webrtc/datachannel/multiple-connections.html on mac debug wk1. History: https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fdatachannel%2Fmultiple-connections.html&platform=mac&flavor=wk1
youenn fablet
Comment 14 2020-03-27 10:10:52 PDT
(In reply to Aakash Jain from comment #13) > (In reply to EWS from comment #12) > > Committed r259111: <https://trac.webkit.org/changeset/259111> > This seems to have broken webrtc/datachannel/multiple-connections.html on > mac debug wk1. > > History: > https://results.webkit.org/?suite=layout- > tests&test=webrtc%2Fdatachannel%2Fmultiple-connections. > html&platform=mac&flavor=wk1 Hum, multiple-connections.html is a Slow test that tries to create connections like crazy. It might be that the new boringssl is much slower in Debug.
youenn fablet
Comment 15 2020-03-27 10:11:18 PDT
Looking at https://build.webkit.org/results/Apple-Catalina-Debug-WK1-Tests/r259111%20(3416)/webrtc/datachannel/multiple-connections-stderr.txt, nothing wrong here, test seems to run normally.
youenn fablet
Comment 16 2020-03-27 10:14:03 PDT
Test takes 22 seconds before boringssl bump.
youenn fablet
Comment 17 2020-03-27 10:20:33 PDT
(In reply to youenn fablet from comment #16) > Test takes 22 seconds before boringssl bump. Test takes 31 seconds after boringssl bump but is timing out. I would have expected a bigger time out here, 150000
youenn fablet
Comment 18 2020-03-27 10:49:38 PDT
This does not repro locally when Tools/Scripts/run-webkit-tests --no-retry LayoutTests/webrtc/datachannel/multiple-connections.html -1 --iterations=50 -f --child-processes=5 This reproes with child-processes=20.
Note You need to log in before you can comment on or make changes to this bug.