Bug 209524

Summary: Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing @tryGetById itself
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: JavaScriptCoreAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209363
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2020-03-24 17:05:05 PDT
Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing @tryGetById itself
Attachments
Patch (4.60 KB, patch)
2020-03-24 17:13 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.62 KB, patch)
2020-03-24 18:41 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-03-24 17:13:49 PDT
Created attachment 394445 [details] Patch
Saam Barati
Comment 2 2020-03-24 17:16:34 PDT
Comment on attachment 394445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394445&action=review > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1441 > + ASSERT(symbol); seems like we should release assert
Saam Barati
Comment 3 2020-03-24 17:16:45 PDT
r=me. nice
Yusuke Suzuki
Comment 4 2020-03-24 17:17:53 PDT
r=me too if EWS gets green :)
Ross Kirsling
Comment 5 2020-03-24 18:41:04 PDT
Created attachment 394456 [details] Patch for landing
EWS
Comment 6 2020-03-24 19:07:45 PDT
Committed r258968: <https://trac.webkit.org/changeset/258968> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394456 [details].
Radar WebKit Bug Importer
Comment 7 2020-03-24 19:08:16 PDT
<rdar://problem/60853767>
Note You need to log in before you can comment on or make changes to this bug.