Bug 209509

Summary: Ignore in-app browser privacy checks for apps with com.apple.private.applemediaservices entitlement
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kate Cheney
Reported 2020-03-24 15:16:39 PDT
These applications do not need the additional quirks provided by the in-app browser privacy checks.
Attachments
Patch (3.04 KB, patch)
2020-03-24 15:23 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (3.07 KB, patch)
2020-03-24 15:29 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2020-03-24 15:51 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2020-03-24 15:17:00 PDT
<rdar://problem/60750956>
Kate Cheney
Comment 2 2020-03-24 15:23:57 PDT
Created attachment 394423 [details] Patch
Kate Cheney
Comment 3 2020-03-24 15:29:59 PDT
Created attachment 394425 [details] Patch
Brent Fulgham
Comment 4 2020-03-24 15:44:52 PDT
Comment on attachment 394425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394425&action=review Looks great! Just fix the include before landing. > Source/WebKit/UIProcess/WebPageProxy.cpp:186 > +#include <wtf/cocoa/Entitlements.h> This needs to be inside the #if PLATFORM(COCOA)
Kate Cheney
Comment 5 2020-03-24 15:51:11 PDT
Created attachment 394428 [details] Patch
Kate Cheney
Comment 6 2020-03-24 15:51:38 PDT
Thanks! Just going to make sure this compiles on gtk before landing.
Brent Fulgham
Comment 7 2020-03-24 15:56:36 PDT
Comment on attachment 394428 [details] Patch Perfect! r=me
EWS
Comment 8 2020-03-24 16:51:11 PDT
Committed r258958: <https://trac.webkit.org/changeset/258958> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394428 [details].
Note You need to log in before you can comment on or make changes to this bug.