| Summary: | [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Lord <clord> | ||||
| Component: | Tools / Tests | Assignee: | Chris Lord <clord> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, clopez, mcatanzaro, pnormand, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Lord
2020-03-24 08:14:20 PDT
Created attachment 394367 [details]
Patch
Comment on attachment 394367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394367&action=review > Tools/ChangeLog:6 > + Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox. An alternative could have been to add this to `env_var_suffixes_to_keep` but I'm also OK with this approach. Explicit is better than implicit usually :) Comment on attachment 394367 [details]
Patch
I agree with explicit being better (though maybe I'll disagree when this comes back and bites us again ;)) so leaving as is.
It would be good if these variables had 'WEBKIT' somewhere in them I think, if we were going to whitelist the suffix.
Yeah, or a WEBKIT_ prefix :) Committed r258910: <https://trac.webkit.org/changeset/258910> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394367 [details]. |