Bug 209449

Summary: Update test262 to commit 79146e5cf48d
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: darin, keith_miller, ross.kirsling, tsavell, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 163417    
Attachments:
Description Flags
Patch none

Alexey Shvayka
Reported 2020-03-23 16:24:54 PDT
Update test262 to commit 79146e5cf48d
Attachments
Patch (1.43 MB, patch)
2020-03-23 16:34 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-03-23 16:34:08 PDT
Created attachment 394324 [details] Patch
Alexey Shvayka
Comment 2 2020-03-23 16:39:19 PDT
(In reply to Alexey Shvayka from comment #1) > Created attachment 394324 [details] > Patch There are 3 tests that timeout. I will fix related bugs in a short time, yet we should consider setting default --timeout to a large finite value.
Keith Miller
Comment 3 2020-03-23 18:40:26 PDT
(In reply to Alexey Shvayka from comment #2) > (In reply to Alexey Shvayka from comment #1) > > Created attachment 394324 [details] > > Patch > > There are 3 tests that timeout. > I will fix related bugs in a short time, yet we should consider setting > default --timeout to a large finite value. Do you know why they timeout?
Alexey Shvayka
Comment 4 2020-03-23 18:55:46 PDT
(In reply to Keith Miller from comment #3) > Do you know why they timeout? Yes, timeouts are intentional: there were no way to author those tests so they would fail with an exception instead of timing out.
Alexey Shvayka
Comment 5 2020-03-24 12:51:18 PDT
There are quite a few skipped Array.prototype tests because of timeouts, please see https://trac.webkit.org/browser/webkit/trunk/JSTests/test262/config.yaml#L85. Most of them will be fixed with https://bugs.webkit.org/show_bug.cgi?id=163417.
Keith Miller
Comment 6 2020-03-24 14:54:33 PDT
(In reply to Alexey Shvayka from comment #4) > (In reply to Keith Miller from comment #3) > > Do you know why they timeout? > > Yes, timeouts are intentional: there were no way to author those tests so > they would fail with an exception instead of timing out. Ah, ok. Tests seem a little contrived but sure.
Keith Miller
Comment 7 2020-03-24 14:55:18 PDT
Comment on attachment 394324 [details] Patch rs=me
EWS
Comment 8 2020-03-24 15:03:21 PDT
Committed r258943: <https://trac.webkit.org/changeset/258943> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394324 [details].
Radar WebKit Bug Importer
Comment 9 2020-03-24 15:04:16 PDT
<rdar://problem/60843677>
Alexey Shvayka
Comment 11 2020-03-24 17:20:10 PDT
Committed r258963: <https://trac.webkit.org/changeset/258963>
Ross Kirsling
Comment 12 2020-03-25 19:10:10 PDT
(In reply to Alexey Shvayka from comment #11) > Committed r258963: <https://trac.webkit.org/changeset/258963> Somehow as of this second commit, test/language/global-code/decl-lex-configurable-global.js is now failing, but it appears that you've already fixed this upstream in https://github.com/tc39/test262/pull/2546, so I guess we just need to sync yet again? :P
Ross Kirsling
Comment 13 2020-03-25 21:29:48 PDT
(In reply to Ross Kirsling from comment #12) > Somehow as of this second commit, > test/language/global-code/decl-lex-configurable-global.js is now failing, > but it appears that you've already fixed this upstream in > https://github.com/tc39/test262/pull/2546, so I guess we just need to sync > yet again? :P Committed r259032: <https://trac.webkit.org/changeset/259032>
Note You need to log in before you can comment on or make changes to this bug.