| Summary: | Update test262 to commit 79146e5cf48d | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||
| Component: | JavaScriptCore | Assignee: | Alexey Shvayka <ashvayka> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | darin, keith_miller, ross.kirsling, tsavell, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 163417 | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Shvayka
2020-03-23 16:24:54 PDT
Created attachment 394324 [details]
Patch
(In reply to Alexey Shvayka from comment #1) > Created attachment 394324 [details] > Patch There are 3 tests that timeout. I will fix related bugs in a short time, yet we should consider setting default --timeout to a large finite value. (In reply to Alexey Shvayka from comment #2) > (In reply to Alexey Shvayka from comment #1) > > Created attachment 394324 [details] > > Patch > > There are 3 tests that timeout. > I will fix related bugs in a short time, yet we should consider setting > default --timeout to a large finite value. Do you know why they timeout? (In reply to Keith Miller from comment #3) > Do you know why they timeout? Yes, timeouts are intentional: there were no way to author those tests so they would fail with an exception instead of timing out. There are quite a few skipped Array.prototype tests because of timeouts, please see https://trac.webkit.org/browser/webkit/trunk/JSTests/test262/config.yaml#L85. Most of them will be fixed with https://bugs.webkit.org/show_bug.cgi?id=163417. (In reply to Alexey Shvayka from comment #4) > (In reply to Keith Miller from comment #3) > > Do you know why they timeout? > > Yes, timeouts are intentional: there were no way to author those tests so > they would fail with an exception instead of timing out. Ah, ok. Tests seem a little contrived but sure. Comment on attachment 394324 [details]
Patch
rs=me
Committed r258943: <https://trac.webkit.org/changeset/258943> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394324 [details]. It looks like the changes in https://trac.webkit.org/changeset/258943/webkit broke 4 test262 tests Build: https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/2358 Log file: https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/2358/steps/test262-test/logs/stdio Committed r258963: <https://trac.webkit.org/changeset/258963> (In reply to Alexey Shvayka from comment #11) > Committed r258963: <https://trac.webkit.org/changeset/258963> Somehow as of this second commit, test/language/global-code/decl-lex-configurable-global.js is now failing, but it appears that you've already fixed this upstream in https://github.com/tc39/test262/pull/2546, so I guess we just need to sync yet again? :P (In reply to Ross Kirsling from comment #12) > Somehow as of this second commit, > test/language/global-code/decl-lex-configurable-global.js is now failing, > but it appears that you've already fixed this upstream in > https://github.com/tc39/test262/pull/2546, so I guess we just need to sync > yet again? :P Committed r259032: <https://trac.webkit.org/changeset/259032> |