Bug 209422

Summary: RemoteAudioSession should listen to GPUProcess messages
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, mkwst, philipj, rniwa, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209575
Attachments:
Description Flags
Patch none

Description youenn fablet 2020-03-23 06:08:23 PDT
RemoteAudioSession should listen to GPUProcess messages
Comment 1 youenn fablet 2020-03-23 06:12:56 PDT
Created attachment 394258 [details]
Patch
Comment 2 EWS 2020-03-23 07:26:39 PDT
Committed r258838: <https://trac.webkit.org/changeset/258838>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394258 [details].
Comment 3 Radar WebKit Bug Importer 2020-03-23 07:27:12 PDT
<rdar://problem/60774066>
Comment 4 Ryosuke Niwa 2020-03-25 18:52:19 PDT
Comment on attachment 394258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394258&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:52
> +    m_process.ensureGPUProcessConnection().messageReceiverMap().addMessageReceiver(Messages::RemoteAudioSession::messageReceiverName(), 0, *this);

Ugh... we shouldn't be using the destination ID of 0. That'll immediately hit an assertion failure: https://bugs.webkit.org/show_bug.cgi?id=209575