Bug 209422 - RemoteAudioSession should listen to GPUProcess messages
Summary: RemoteAudioSession should listen to GPUProcess messages
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Reported: 2020-03-23 06:08 PDT by youenn fablet
Modified: 2020-03-25 18:52 PDT (History)
10 users (show)

See Also:

Patch (2.09 KB, patch)
2020-03-23 06:12 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-23 06:08:23 PDT
RemoteAudioSession should listen to GPUProcess messages
Comment 1 youenn fablet 2020-03-23 06:12:56 PDT
Created attachment 394258 [details]
Comment 2 EWS 2020-03-23 07:26:39 PDT
Committed r258838: <https://trac.webkit.org/changeset/258838>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394258 [details].
Comment 3 Radar WebKit Bug Importer 2020-03-23 07:27:12 PDT
Comment 4 Ryosuke Niwa 2020-03-25 18:52:19 PDT
Comment on attachment 394258 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=394258&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:52
> +    m_process.ensureGPUProcessConnection().messageReceiverMap().addMessageReceiver(Messages::RemoteAudioSession::messageReceiverName(), 0, *this);

Ugh... we shouldn't be using the destination ID of 0. That'll immediately hit an assertion failure: https://bugs.webkit.org/show_bug.cgi?id=209575