Summary: | Web Inspector: use native datetime-local picker for changing `expires` value in cookie popover | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, hi, inspector-bugzilla-changes, m.kurz+webkitbugs, spamfaenger, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 31157, 119175 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Devin Rousso
2020-03-21 19:52:37 PDT
Created attachment 423418 [details]
Patch
Comment on attachment 423418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review > Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135 > + data.expires = formatDate(cookie.expires || this._defaultExpires()); Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now? Comment on attachment 423418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review >> Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135 >> + data.expires = formatDate(cookie.expires || this._defaultExpires()); > > Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now? AFAIU this is the format expected by `<input type="datetime-local">` according to @Aditya Keerthi. The "local" part of "datetime-local" means that it will always be based on the local time. Comment on attachment 423418 [details]
Patch
r=me. We may get pushback if this breaks localizations.
Committed r274593: <https://commits.webkit.org/r274593> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423418 [details]. |